-
Notifications
You must be signed in to change notification settings - Fork 54
Feature/hostname logging v5 #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stardothosting
wants to merge
13
commits into
corazawaf:main
Choose a base branch
from
stardothosting:feature/hostname-logging-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/hostname logging v5 #209
stardothosting
wants to merge
13
commits into
corazawaf:main
from
stardothosting:feature/hostname-logging-v5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2025
|
jcchavezs
reviewed
Apr 19, 2025
tx.ProcessLogging() | ||
_ = tx.Close() | ||
}() | ||
repl := r.Context().Value(caddy.ReplacerCtxKey).(*caddy.Replacer) | ||
repl.Set("http.transaction_id", id) | ||
repl.Set("http.transaction_id", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unique_id and improve hostname logging in WAF violation logs
Background
This PR addresses part of issue #75 where hostname information is missing or empty in WAF logs. While the core issue of empty
[hostname ""]
in Coraza logs remains to be solved at a deeper level, this PR improves log correlation by:This allows operators to correlate WAF events across multiple domains/hostnames until the core hostname logging issue is resolved in Coraza.
Changes
Example Log Output
Testing Done
Related Issues