-
Notifications
You must be signed in to change notification settings - Fork 26
chore: add helm chart #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sounds good. We are working on the release process. Another thing I'm thinking is maybe having an independent project below the CC: @jcchavezs @M4tteoP @fionera @jptosso What do you think? |
I would also like to see this in a seperate repository as releasing changes is complicated when having it in the same repo |
Separate repository is the best. |
Perfect. Let me create the repo and will be back. |
Ok, created https://github.com/corazawaf/charts I've throw there basic scaffolding for testing. Let's see if it works properly. Feel free to add PRs for the release part also. |
@fzipi thank you for the updates! Does this mean that once coraza-spoa has configured proper semver image releases, I can pr this chart to that new repo, and we'll continue with the actual review over there? |
Yes! |
I will close this then. Thank you very much for your work @hedgieinsocks |
@fionera sure, I'm ready to pr in the new repo once the 0.2.0 image is out https://github.com/corazawaf/coraza-spoa/pkgs/container/coraza-spoa It looks like image release is not yet synced with release-please, could you guys please look into it? |
For the record, the chart PR has been moved to corazawaf/charts#2 |
Introducing an official helm chart will be yet another step towards productionizing this project for k8s crowd.
If that is something you could agree to, then in the following PRs we will configure testing, docs and release workflows:
But perhaps before merging this, it makes sense to revisit CI and go for tagged versioned image releases only. Cause currently, we are building with each merge and helm image tag will be always one step behind.
Wdyt?