Feature/schema improvements #1384
Open
+960
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felipe Zipitría <[email protected]>
… validation - Added full JSON Schema validation using kaptinlin/jsonschema - Added XML Schema validation using terminalstatic/go-xsd-validate - Implemented lazy initialization to improve performance - Added test cases
…o v4.10.0 in testing/coreruleset/go.mod (#1341) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
+ Coverage 84.34% 84.47% +0.13%
==========================================
Files 170 172 +2
Lines 9933 10042 +109
==========================================
+ Hits 8378 8483 +105
- Misses 1310 1312 +2
- Partials 245 247 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some rework on top of the great work done in #1343. One thing I believe we should discuss is if we need https://github.com/owasp-modsecurity/ModSecurity/wiki/Reference-Manual-(v3.x)#user-content-SecXmlExternalEntity to make explicit the collection of those json variables we record additionally now (I would like to hear from @M4tteoP and @airween). Otherwise @cognitivegears do you mind trying this branch?