Skip to content

Made the GCP project configurable as a variable so it doesn't have to be set in the provider #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025

Conversation

HassanBaker
Copy link
Collaborator

Description

Made the GCP project configurable as a variable so it doesn't have to be set in the provider.

Related to issue corelight/terraform-gcp-enrichment Issue 8

Type of change

Please delete options that are not relevant.

  • Bug Fix
  • New Feature
  • This change requires a documentation update

How Has This Been Tested?

Deployed and destroyed successfully

@HassanBaker HassanBaker requested a review from jmfiola June 6, 2025 15:59
jmfiola
jmfiola previously approved these changes Jun 6, 2025
Copy link
Collaborator

@thathaneydude thathaneydude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md to reflect the new required variable. Thanks!

@HassanBaker HassanBaker merged commit ddf551c into main Jun 9, 2025
1 check passed
@HassanBaker HassanBaker deleted the hbaker/make-project-configurable-by-variable branch June 9, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants