bios/efi: always use fsfreeze_thaw_cycle

[champtar]

This is required when we use XFS, but it doesn't hurt to always use fsfreeze_thaw_cycle.

[openshift-ci]

Hi @champtar. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gemini-code-assist]

Code Review

This pull request replaces syncfs() calls with fsfreeze_thaw_cycle() to ensure filesystem journals are properly flushed, which is particularly important for XFS. This change improves correctness and robustness by handling errors that were previously ignored. The review suggests simplifying the new calls by passing directory handles directly, avoiding unnecessary open_file calls.