Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/testiso: enable 4k images tests for s390x #3574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kola/testiso: enable 4k images tests for s390x #3574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mantle/cmd/kola/testiso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,14 @@ var (
}
tests_s390x = []string{
"iso-live-login.s390fw",
"iso-live-login.4k.s390fw",
"iso-offline-install.s390fw",
// https://github.com/coreos/fedora-coreos-tracker/issues/1434
// "iso-offline-install.mpath.s390fw",
// https://github.com/coreos/fedora-coreos-tracker/issues/1261
// "iso-offline-install.4k.s390fw",
"iso-offline-install.4k.s390fw",
"iso-offline-install.mpath.s390fw",
"pxe-online-install.s390fw",
"pxe-online-install.4k.s390fw",
"pxe-offline-install.s390fw",
"miniso-install.s390fw",
"pxe-offline-install.4k.s390fw",
Comment on lines +106 to +113
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should enable so many 4k tests. The goal here is we get a strategic covering of the possible scenarios without trying to cover them all. i.e. let's add maybe 2 or 3 versus 5. Or maybe we can convert some other tests that are running into 4k ones?

"miniso-install.nm.s390fw",
"miniso-install.4k.nm.s390fw",
// FIXME https://github.com/coreos/fedora-coreos-tracker/issues/1657
Expand Down
Loading