Skip to content

kola: support relative indices for --build arg #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jul 8, 2024

I often want to target the previous build when e.g. doing cosa run or kola testiso to compare between an older and newer build.

Instead of having to copy/paste the previous build ID, let's support passing negative indices like -1 for the previous build, -2 for the one before that, etc...

This is similar to the journalctl --boot N syntax.

I often want to target the previous build when e.g. doing `cosa run` or
`kola testiso` to compare between an older and newer build.

Instead of having to copy/paste the previous build ID, let's support
passing negative indices like `-1` for the previous build, `-2` for the
one before that, etc...

This is similar to the `journalctl --boot N` syntax.
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but LGTM. Not tested.

Copy link
Member

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! looks sane to me

@jlebon jlebon merged commit b241f8b into coreos:main Jul 10, 2024
5 checks passed
@jlebon jlebon deleted the pr/main branch July 10, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants