Link bootc custom #4346
Open
Link bootc custom #4346
+7
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains two beneficial changes. The documentation in docs/custom.md is updated to guide users towards the bootc project for creating custom operating systems, which is the modern approach. The systemd unit definition in mantle/platform/qemu.go is improved for better robustness and startup ordering by adjusting its dependencies. Both changes are well-implemented and positive contributions to the project. The PR title 'Link bootc custom' accurately describes the documentation change, but a more descriptive title reflecting both changes could be beneficial for future reference. Overall, the changes are solid and I have no further comments.
I actually ended up on this page when I was wondering about the status of making disk images after a podman build. Update it. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
link-bootc-custom
branch
from
63f4af3 to
7001e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.