-
Notifications
You must be signed in to change notification settings - Fork 98
cargo: bump MSRV to 1.90.0 #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the Minimum Supported Rust Version (MSRV) to 1.90.0. The changes in Cargo.toml and the corresponding documentation update in docs/release-notes.md are appropriate and consistent. To ensure the project remains in a consistent state, I recommend also running cargo update to regenerate the Cargo.lock file against the new MSRV. Additionally, it would be beneficial to verify that the Rust toolchain version used in the CI/CD pipelines is updated to 1.90.0 or newer to match this change.
1e6eab3 to
db3d1a5
Compare
|
Hold on, maybe the CI could be simpler once we have coreos/coreos-ci-lib#167 |
db3d1a5 to
814e4f9
Compare
|
Looks these tests are also need none root. |
No description provided.