Skip to content

Conversation

@HuijingHei
Copy link
Member

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the Minimum Supported Rust Version (MSRV) to 1.90.0. The changes in Cargo.toml and the corresponding documentation update in docs/release-notes.md are appropriate and consistent. To ensure the project remains in a consistent state, I recommend also running cargo update to regenerate the Cargo.lock file against the new MSRV. Additionally, it would be beneficial to verify that the Rust toolchain version used in the CI/CD pipelines is updated to 1.90.0 or newer to match this change.

@HuijingHei HuijingHei force-pushed the bump-rust-1.90 branch 7 times, most recently from 1e6eab3 to db3d1a5 Compare January 6, 2026 09:52
@HuijingHei
Copy link
Member Author

Hold on, maybe the CI could be simpler once we have coreos/coreos-ci-lib#167

@HuijingHei
Copy link
Member Author

Looks these tests are also need none root.

[2026-01-06T13:50:12.121Z] Running test: iso-offline-install-iscsi.ibft.uefi
[2026-01-06T13:50:12.121Z] [2026-01-06T13:50:03Z ERROR virtiofsd] can't apply the child capabilities: failed to sync capabilities with the kernel
[2026-01-06T13:50:12.121Z] qemu-system-x86_64: -chardev socket,id=virtiofschar0,path=/var/tmp/mantle-qemu1668519661/virtiofsd-0.sock: Failed to connect to '/var/tmp/mantle-qemu1668519661/virtiofsd-0.sock': Connection refused
[2026-01-06T13:50:33.971Z] FAIL: iso-offline-install-iscsi.ibft.uefi (0s)
[2026-01-06T13:50:33.971Z]     running iso: failed to establish qmp connection: dial unix /var/tmp/mantle-qemu1668519661/qmp-1767707403515000315.sock: connect: connection refused
[2026-01-06T13:50:33.971Z] Running test: iso-offline-install-iscsi.ibft-with-mpath.bios
[2026-01-06T13:50:34.894Z] [2026-01-06T13:50:34Z ERROR virtiofsd] can't apply the child capabilities: failed to sync capabilities with the kernel
[2026-01-06T13:50:35.818Z] qemu-system-x86_64: -chardev socket,id=virtiofschar0,path=/var/tmp/mantle-qemu1801902470/virtiofsd-0.sock: Failed to connect to '/var/tmp/mantle-qemu1801902470/virtiofsd-0.sock': Connection refused
[2026-01-06T13:51:07.810Z] FAIL: iso-offline-install-iscsi.ibft-with-mpath.bios (0s)
[2026-01-06T13:51:07.810Z]     running iso: failed to establish qmp connection: dial unix /var/tmp/mantle-qemu1801902470/qmp-1767707434722018814.sock: connect: connection refused
[2026-01-06T13:51:07.810Z] Running test: iso-offline-install-iscsi.manual.bios
[2026-01-06T13:51:07.810Z] [2026-01-06T13:51:05Z ERROR virtiofsd] can't apply the child capabilities: failed to sync capabilities with the kernel
[2026-01-06T13:51:07.810Z] qemu-system-x86_64: -chardev socket,id=virtiofschar0,path=/var/tmp/mantle-qemu3918585589/virtiofsd-0.sock: Failed to connect to '/var/tmp/mantle-qemu3918585589/virtiofsd-0.sock': Connection refused
[2026-01-06T13:51:39.808Z] FAIL: iso-offline-install-iscsi.manual.bios (0s)
[2026-01-06T13:51:39.808Z]     running iso: failed to establish qmp connection: dial unix /var/tmp/mantle-qemu3918585589/qmp-1767707465898579044.sock: connect: connection refused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant