tests/platforms: add test for Azure SR-IOV udev rules #3947
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new test to verify that Azure SR-IOV network interfaces are correctly marked as unmanaged by NetworkManager. The test script is well-structured and the logic is sound. I have one suggestion to improve the efficiency of the script by reducing redundant calls to nmcli within a loop. Overall, this is a valuable addition to the test suite.
aaradhak
force-pushed
the
azuresriov
branch
3 times, most recently
from
8bebbcc to
9e3255c
Compare
src/config
Outdated
| @@ -0,0 +1 @@ | |||
| /home/aaradhak/coderepo/fedora-coreos-config No newline at end of file | |||
There was a problem hiding this comment.
You probably did not want to include this one
There was a problem hiding this comment.
my bad, I ll remove this
|
You also have an override file that you probably don't want there: overrides/rootfs/usr/libexec/ignition-apply |
|
Test itself LGTM. Obviously removing files that we don't want in this PR should happen before merge. @marmijo mind a look as well since you are familiar with the Azure pieces? |
|
Yes, I have removed the unwanted files (it got added here accidentally) and also made the suggested change |
Introduce a new test which verifies that udev rules for Azure SR-IOV network interfaces correctly mark them as unmanaged by NetworkManager. It only runs on Azure and uses Standard_D2s_v3 or larger instance type with Accelerated Networking enabled. The test checks that SR-IOV interfaces (PCI devices with vendor drivers like mlx5_core) have the AZURE_UNMANAGED_SRIOV property set, and that NetworkManager respects this property by leaving them unmanaged.
| if [ -e "$iface/device/driver" ]; then | ||
| driver=$(basename "$(readlink "$iface/device/driver")") | ||
| # SR-IOV interfaces are on PCI bus and not vmbus (hv_netvsc is the synthetic interface) | ||
| if [ "$driver" != "hv_netvsc" ] && [ -e "$iface/device/subsystem" ]; then |
There was a problem hiding this comment.
In testing, I think were using mlx5_core here to determine which device to work on. Does this driver also work?
There was a problem hiding this comment.
No i dont think we would need the driver hv_netvsc for this test.
| ## platforms: azure | ||
| ## # This test requires an instance type that supports Accelerated Networking (SRIOV) | ||
| ## # Standard_D2s_v3 and larger sizes support Accelerated Networking | ||
| ## instanceType: "Standard_D2s_v3" |
There was a problem hiding this comment.
We shouldn't need to declare an instance type since Standard_D2s_v3 is the default for x86_64.
I didn't think about this when we were testing manually, but is SR-IOV networking supported on aarch64?
There was a problem hiding this comment.
sounds good, I ll remove this reference.
4 participants
Introduce a new test which verifies that udev rules for Azure SR-IOV network interfaces correctly mark them as unmanaged by NetworkManager. It only runs on Azure and uses Standard_D2s_v3 or larger instance type with Accelerated Networking enabled.
The test checks that SR-IOV interfaces (PCI devices with vendor drivers like mlx5_core) have the AZURE_UNMANAGED_SRIOV property set, and that NetworkManager respects this property by leaving them unmanaged.