drop obsolete image.yaml settings; refactor #3972
Open
+14
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for this in COSA was dropped long ago. coreos/coreos-assembler@efbae77
We don't use an OSTree for a remote any longer and the vestiges of using this setting in create_disk.sh were long ago deleted.
These settings were only ever consumed in the legacy `cosa build` path where rpm-ostree was run directly (i.e. not in the build via container tools path). Let's delete them since they are of no use to us now that we have moved to the new build path.
This was obsolete after moving to build with OSBuild. See coreos/coreos-assembler#4421
These basically stopped being used once we switched to OSBuild and any coded use of them got deleted when create_disk.sh got removed [1]. [1] coreos/coreos-assembler@d37958a
There wasn't much point in have two levels of indirection here. Let's merge everything into one file.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively cleans up and refactors the image configuration by dropping obsolete settings from image-default.yaml and migrating relevant settings to image-base.yaml. The changes align well with the stated goal of removing legacy and unused configurations, improving the clarity and maintainability of the image definitions. The removal of ignition-network-kcmdline and ostree-remote from image-base.yaml and the complete removal of image-default.yaml are consistent with the provided commit messages. New VMware and AWS settings have been added to image-base.yaml with appropriate comments, enhancing the configuration for these platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small cleanups. See individual commit messages:
cosa buildsettings