Add optionally-installed grub2 code #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Pairs with coreos/bootupd#543 |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Oct 12, 2023
This hard requires - coreos/bootupd#543 - coreos/ignition#1728
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Oct 12, 2023
This hard requires - coreos/bootupd#543 - coreos/ignition#1728
Member
Author
|
Updated for all comments |
This pairs with coreos/bootupd#543 Basically we want bootupd to take care of installing this. Add the config here (where it more closely arguably belongs) so that it can be optionally installed. My proposal for at least the Fedora packaging of Ignition is that we unconditionally depend on bootupd and install this, because there's no one there using Ignition who doesn't want bootupd.
Member
|
Just tweaked the comment to add more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pairs with coreos/bootupd#543 Basically we want bootupd to take care of installing this. Add the config here (where it more closely arguably belongs) so that it can be optionally installed.
My proposal for at least the Fedora packaging of Ignition is that we unconditionally depend on bootupd and install this, because there's no one there using Ignition who doesn't want bootupd.