compose: Allow missing repos key and add --source-root flag
#5136
Conversation
In fedora-bootc, we want the API to set the Fedora version to use to be `--from quay.io/fedora/fedora:<N>`, from which the repo files are copied. So in that case, we just want the default repos that are enabled in that base image to be used. Support this use case in rpm-ostree by just defaulting to that when `repos` is not specified. Related: https://gitlab.com/fedora/bootc/tracker/-/issues/39
|
This is including #5118 right? |
Not quite. :) See #5118 (comment) |
In fedora-bootc, we want the API to set the Fedora version to use to be `--from quay.io/fedora/fedora:<N>`, from which the releasever is set. Support this use case in rpm-ostree by adding a new `--source-root` option to point libdnf at a different mount root to determine the releasever. (See also previous commit.) Related: https://gitlab.com/fedora/bootc/tracker/-/issues/39
jlebon
force-pushed
the
pr/repos-releasever
branch
from
5bdc832
to
06e2906
Compare
|
In your patches is it setting |
Not quite. You can see it in the last commit of https://gitlab.com/fedora/bootc/base-images/-/merge_requests/64 (well first commit I guess because Gitlab reverses the list). https://gitlab.com/fedora/bootc/tracker/-/issues/39#note_2174172493 is the entrypoint for all these PRs BTW. Notably, this PR and https://gitlab.com/fedora/bootc/base-images/-/merge_requests/64 go together and are follow-ups to https://gitlab.com/fedora/bootc/base-images/-/merge_requests/63. |
|
Ahhh right because we're separating the repos container and the builder container. Yeah, a reasonable general case but I could actually see an argument that we should encourage conflating them. I think I'd like to have a nice high level |
|
Uh, no idea what's going on with that clang failure...just clicked retry |
|
CI is broken on #5137. Just going to force this in. |
Both of those are motivated by the fedora-bootc use case to clean up the container-native compose path. See individual commit messages.
Related: https://gitlab.com/fedora/bootc/tracker/-/issues/39