feat: implement skipping TLS verification #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a CLI flag for wait4x to disable TLS verification but no such option for the HTTP client. This change replaces the specific flag for wait4x with a global flag `skip-tls-verification`, that configures both wait4x and the HTTP client. Fixes coreruleset#503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a CLI flag for wait4x to disable TLS verification but no such option for the HTTP client.
This change replaces the specific flag for wait4x with a global flag
skip-tls-verification, that configures both wait4x and the HTTP client.Fixes #503