Skip to content

feat: improve nginx resolver configuration #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

theseion
Copy link
Contributor

  • use all entries from /etc/resolv.conf
  • support IPv6 addresses in /etc/resolv.conf
  • make resolver options configurable
  • use better variable name

Replaces #364

@theseion theseion requested a review from fzipi July 23, 2025 05:54
@theseion theseion added the enhancement New feature or request label Jul 23, 2025
fzipi
fzipi previously approved these changes Jul 23, 2025
@fzipi
Copy link
Member

fzipi commented Jul 23, 2025

Tests are failing with:

2025/07/23 05:59:24 [emerg] 1#1: host not found in resolver "RESOLVER" in /etc/nginx/nginx.conf:18
nginx: [emerg] host not found in resolver "RESOLVER" in /etc/nginx/nginx.conf:18

- use all entries from /etc/resolv.conf
- support IPv6 addresses in /etc/resolv.conf
- make resolver options configurable
- use better variable name

Replaces coreruleset#364
@theseion theseion force-pushed the improve-resolver-configuration branch from 7094394 to 3af1eec Compare July 24, 2025 05:18
@fzipi fzipi enabled auto-merge July 24, 2025 12:14
@fzipi fzipi merged commit 1286b98 into coreruleset:main Jul 24, 2025
5 checks passed
@theseion theseion deleted the improve-resolver-configuration branch July 24, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants