fix: FPs in SQL query on multiple places #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EsadCetiner
approved these changes
Dec 1, 2025
Member
EsadCetiner
left a comment
EsadCetiner
left a comment
There was a problem hiding this comment.
Can you change the PR title to something more descriptive before merging?
Member
Author
|
Done. |
Member
Author
|
Will add few more tests soon. |
This test is disabled due to unsupported plugin configuration changes.
EsadCetiner
requested changes
Dec 4, 2025
| ctl:ruleRemoveTargetById=951220;RESPONSE_BODY,\ | ||
| ctl:ruleRemoveTargetById=953100;RESPONSE_BODY" | ||
|
|
||
| SecRule ARGS:route "@streq /preferences/features" \ |
Member
There was a problem hiding this comment.
Can you add a short comment to this rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example typo (missing backtick) in SQL query caused FP:
Fixes: #37