Skip to content

refactor: rename parser directory #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Dec 8, 2024

what

  • move parser directory with antlr parser sources to g4
  • split parser generation for python module and golang module

why

  • future decoupling of python and golang code from the g4 files

@fzipi fzipi force-pushed the refactor/rename-parser-directory branch 3 times, most recently from 018dc23 to 78aa7e4 Compare December 8, 2024 16:06
@fzipi fzipi marked this pull request as ready for review December 8, 2024 16:11
Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume it works... ;)

@fzipi
Copy link
Member Author

fzipi commented Dec 9, 2024

It doesn't fully yet. Still need to review it as the porting from the golang version has some differences that I'm trying to understand...

@fzipi
Copy link
Member Author

fzipi commented Mar 17, 2025

I'm going to split this one in two. The refactoring is needed, and will do that first. Then will push the python changes.

@fzipi fzipi force-pushed the refactor/rename-parser-directory branch 2 times, most recently from 7c118b5 to bdf38ad Compare March 18, 2025 18:52
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the refactor/rename-parser-directory branch from bdf38ad to 18f3955 Compare March 18, 2025 18:53
@fzipi fzipi merged commit 0e84a25 into main Mar 18, 2025
1 check passed
@fzipi fzipi deleted the refactor/rename-parser-directory branch March 18, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants