Skip to content

refactor: excluded vars and collection length #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

refactor: excluded vars and collection length #36

merged 3 commits into from
Jun 16, 2025

Conversation

Agustindeleon
Copy link
Contributor

what

  • added parser event for negated vars (!REQUEST_URI)
  • added parser event for collection length (&TX:crs_setup_version)

why

  • previously, tokens were recognized, but the event was not generated. As a consequence, the listener couldn't identify whether a var is excluded or not

@Agustindeleon Agustindeleon changed the title refactor: excluded vars and collection lenght refactor: excluded vars and collection length Jun 15, 2025
fzipi
fzipi approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fzipi fzipi merged commit 584dbd1 into coreruleset:main Jun 16, 2025
1 check passed
@fzipi fzipi deleted the refactor/excludedVars branch June 16, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agustindeleon @fzipi