Fixed uninstall process for services sharing same daemon directory.#131
Open
jdziat wants to merge 2 commits intocoreybutler:masterfrom
Open
Fixed uninstall process for services sharing same daemon directory.#131jdziat wants to merge 2 commits intocoreybutler:masterfrom
jdziat wants to merge 2 commits intocoreybutler:masterfrom
Conversation
…ame daemon directory.
Owner
|
Did anything actually change in the daemon.js (first commit)? It looks like the code didn't actually change, but it got moved all over the place. |
Collaborator
Author
|
The block of code was removed from lines 496 to 512 and replaced with just the |
Owner
|
@jdziat - could you rebase to prevent merge conflicts? I'll merge this and make you a maintainer as soon as that happens. Sorry for the delay (had alot come up over the last week and a half). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If multiple services exist for the same daemon directory the current uninstall method tries to remove all documents within the daemon directory. Not just the one being uninstalled. This may leave an artifact from extra files created and the folder itself but that would be preferable to the other services '.exe' getting deleted.
changed
to
me.emit('uninstall');