Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Header to Home #459

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Added Header to Home #459

merged 1 commit into from
Sep 30, 2023

Conversation

kevin-lin12
Copy link
Contributor

@kevin-lin12 kevin-lin12 commented Sep 26, 2023 •
edited
Loading

Summary

This pull request adds an H1 tag to the file "home.tsx".

  • Added H1 tag to Home

Test Plan

Screenshot 2023-09-26 at 5 55 37 PM

Notes

Breaking Changes

@kevin-lin12 kevin-lin12 requested a review from a team as a code owner September 26, 2023 21:56
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 1.

@kevin-lin12 kevin-lin12 changed the title Added H1 tag to Home page Added Header to Home Sep 26, 2023
Atikpui007
Atikpui007 reviewed Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@Atikpui007 Atikpui007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but lets wait on design team to confirm the placement of the Dates

@Atikpui007 Atikpui007 merged commit 37b0a2e into master Sep 30, 2023
5 checks passed
@Atikpui007 Atikpui007 deleted the kl628/home-page-h1 branch September 30, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atikpui007 Atikpui007 Atikpui007 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin-lin12 @dti-github-bot @Atikpui007