Refocus calendar button after calendar modal close in Home page #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 31. |
Atikpui007
requested changes
Sep 30, 2023
There was a problem hiding this comment.
Very thorough PR
I did some research and could not find anything on native react-date picker methods that could address the issue like you said.
Good use of the custom Input Ref to address the focus issue
I performed the test and it works as expected
Some notes - I know this wasn't part of the ticket but since there are buttons without ARIA labels can you ensure they are correctly labeled so as not to come back to make accessibility changes
|
I pulled the PR and after selecting a day, it indeed refocuses on the calendar element. PR works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue 4 of Keyboard Testing task
Test Plan
After opening the calendar and selecting +interacting with a day (thus closing the calendar popup), browser focus is now pointed at the button that opens the calendar, instead of an invisible element like before.
Notes
I had to do a weird trick with the
customInputRefprop in theDatePickercomponent to get the ref to the button to persist. Unfortunately,react-datepickerdoesn't seem to provide a better way to focus on our custom button input (at least I couldn't find anything).