Allow phone number dashes

[selenaliu1]

Summary

• edited Rider modal and Employee modal to allow dashes in the phone number

Test Plan

Valid inputs:


Invalid inputs (too long):

Notes

• Accepts 10-12 characters, but only takes the first 10 numbers

Breaking Changes

[dti-github-bot]

[diff-counting] Significant lines: 11.

[raissaji]

Looks good! A suggestion is to explicitly define where the dashes should be, so that a phone number like 40-98204-652 will be flagged as invalid.

[andrewschoi]

maxLength and minLength are not needed. Change pattern to be a regular expression for a phone number.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions

            ref={register({
              required: true,
              pattern: /^[0-9-]{10,}$/,
              maxLength: 12,
              minLength: 10,
            })}

[Atikpui007]

Define a validity check to ensure that dashes cannot just be placed anywhere.