Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit visual indicator for active vs inactive students #500

Closed
wants to merge 1 commit into from
Closed

Edit visual indicator for active vs inactive students #500

wants to merge 1 commit into from

Conversation

selenaliu1
Copy link
Contributor

Summary

Edited visual indicator so that red line shows only when a user's status is inactive and their end date has passed.

Test Plan

Screenshot 2024-03-09 at 4 01 26 PM Red lines only when they're inactive.

Notes

  • Some students with end dates that have passed have activity status active when it should be inactive

Breaking Changes

@selenaliu1 selenaliu1 requested a review from a team as a code owner March 9, 2024 21:04
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 2.

@Atikpui007
Copy link
Collaborator

Closing this branch because we are moving towards a new implementation for the inactive and active studets

@Atikpui007 Atikpui007 closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selenaliu1 @dti-github-bot @Atikpui007