Location Modal #505
Open
Location Modal #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 80. |
namanhboi
reviewed
Mar 24, 2024
selenaliu1
reviewed
Mar 25, 2024
- Formatted input boxes and titles according to Figma designs - Add appropriate error messages with accurate functionality - Add Clear All and Back buttons
…into rj353/location_modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is for implementing the redesign of the Location Modal. So far, the following changes have been made:
This PR is incomplete, please read the Notes!
Test Plan
Screen.Recording.2024-04-15.at.9.50.12.PM.mov
Here, I demonstrate how the Clear All button functions. I also show the error messages appearing when the name or address is not inputted. According to the Figma design, there is no error message if the pickup/dropoff information is blank, so I removed its requirement.
Notes
Important: The clear all button doesn't work for editing a location that's already been created, as shown in the screen recording below. Also, when an already created location is edited, the website needs to be reloaded in oder to show the changes (we want the changes to show up immediately). Back button is also not yet implemented. These issues are not addressed in this PR.
Screen.Recording.2024-04-15.at.9.53.26.PM.mov
Breaking Changes
None