-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select Component - dropdown with fuzzy search and multi-select capability #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[diff-counting] Significant lines: 381. |
Atikpui007
changed the title
Select Component - dropdown with fuzzy search [WIP]
Select Component - dropdown with fuzzy search
Mar 27, 2024
Atikpui007
changed the title
Select Component - dropdown with fuzzy search
Select Component - dropdown with fuzzy search and multi-select capability
Mar 27, 2024
namanhboi
reviewed
Apr 4, 2024
Atikpui007
changed the title
Select Component - dropdown with fuzzy search and multi-select capability
[WIP]Select Component - dropdown with fuzzy search and multi-select capability
May 6, 2024
Atikpui007
changed the title
[WIP]Select Component - dropdown with fuzzy search and multi-select capability
Select Component - dropdown with fuzzy search and multi-select capability
Oct 5, 2024
namanhboi
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is aimed at introducing a new component / library which solves the problem of having searchable select dropdowns
react-select
library which comes with predefined features such as multi-select, searchable select dropdown, etcThe goal is to ensure that all the dropdowns make use of this component
Test Plan
To test the functionality of
react-select
Screen.Recording.2024-03-27.at.1.07.45.PM.mov
Notes
Read on the react-select component here
React-select
library requires a specific type of options to work~~So it is necessary to transform the datalist into a supportable type for the Select component ~~
Fixed the react-select component to return only the value
Breaking Changes
Bug with the transforming of options - results in multiple options having the same keys. Causes the website to build a map that is arbitrarily large.Squashed bug by introducing dependency array into the useEffect hook in the
riderInfo.tsx
file. Issue was with the constant updating of the dropdown menu causing performance and web crashes