-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the success toast to reflect Lazim's design #512
Open
namanhboi
wants to merge
7
commits into
master
Choose a base branch
from
nd433/successModal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[diff-counting] Significant lines: 185. |
Atikpui007
requested changes
Apr 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a pretty good PR. I left a couple of comments that should be addressed. Also the expected behavior of modals and by extension this success/ failure toast should be that when any other part of the page is clicked it goes away.
frontend/src/components/ConfirmationToast/ConfirmationToast.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/ConfirmationToast/ConfirmationToast.tsx
Outdated
Show resolved
Hide resolved
Atikpui007
previously approved these changes
Sep 20, 2024
… back to home, also had a problem with adding a new student, internal server error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the design of the success toast to match this design. You click on continue or the X to close the toast.
Locations.-.Carriage.-.Google.Chrome.2024-04-14.12-41-08.mp4
I just changed the design of the toast, so to make a toast appear, you just need to use showToast from useToast in toastContext just like before.
Note that the success modal will stay open even if you switch into a different page. I don't know if this is the intended behavior, but I can change it upon request.
Also, in the file AuthManager.tsx, Toast was used directly, which I don't think is correct since we have toastContext which manages all the calling of the toasts. I changed the code to use toastContext and it compiled but I don't know how to see the changes made in the frontend.
Test Plan
I tested the success modal when adding new employees and locations, but I wasn't able to add students for some reason so I haven't been able to test it on that.
I tried it on different screen sizes and on small screens:
The modal is too big, so I would need to do a media export in the future.