Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Rotating Cursor Feature with Dependency Fixes #229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Shengle-Dai
Copy link
Collaborator

Summary

Implemented the rotating cursor feature—updating the direction of the marker/cursor based on the user's magnetic heading direction.

  • fixed dependency issues on the local machine
  • implemented the core functionality to update the cursor rotation with the device's magnetic heading.

Test Plan

  • Simulate different compassHeading values to verify the cursor’s update.
  • Test the feature on TestFlight to ensure performance.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2024

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 55.

@3TTemi
Copy link
Contributor

3TTemi commented Oct 28, 2024

Looks good! I think this solution will work.
However, I would suggest adding a check for null values or defaulting the rotation to currentLocation.heading, as was used before. Additionally, I noticed that you didn't reference FlutterCompass in the dispose function. I'm not entirely sure how flutter_compass works, but if it streams data, it might need to be canceled or disposed of in that function as well.
Lastly, make sure that in the final PR, the mock data is either removed or moved to a separate function or utility file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants