Jc2755/refactor challenges journeys #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e numbers - Adjusted progress bar width to dynamically scale based on the number of digits in total points, achievements, etc., providing better visual alignment. - Implemented formatting to shorten large numbers (e.g., 1500 becomes 1.5K) for improved readability.
…UI changes to profile page.
|
[diff-counting] Significant lines: 284. |
3TTemi
reviewed
Dec 9, 2024
| constraints.maxWidth, | ||
| height: 13, | ||
| alignment: Alignment.centerLeft, | ||
| child: Container( |
There was a problem hiding this comment.
Instead of having a container with a another container inside of it, the BoxDeocration should be able to be applied to the outer container.
|
Nice job abstracting out repetitive code. I still see a lot of places where we're using static inputs for attributes like top and height. We can start transitioning these to MediaQuery where relevant to maintain a dynamic UI. I also left a comment about reducing the nesting of Container widgets, which should help make the code cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing abstracting repetitive logic into utility functions to improve reusability and maintainability.
Remaining TODOs: