-
Notifications
You must be signed in to change notification settings - Fork 1
Timer feature #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Timer feature #258
Conversation
| SvgPicture.asset( //turn timer red when less than 5 minutes left | ||
| "assets/icons/timerbg_red.svg" | ||
| ) : | ||
| SvgPicture.asset( "assets/icons/timerbg.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job Amber! I think one suggestion I have here is that instead of using static SVGs for the timer background, consider switching to a responsive Container with dynamic colors. This will scale better, is less taxing on memory/processing, avoids the need for external assets, and might make more sense intuitively. Otherwise, awesome job and progress on the timer feature!
|
[diff-counting] Significant lines: 145. |
… to events to frontend, change tests to skip websocket operations
… as4288-ta375/timer-feature
…/cornell-go into as4288-ta375/timer-feature
Summary
This pull request is the first step towards implementing the timer feature for challenges.
Remaining TODOs:
Test Plan