Skip to content

Conversation

@jiminkim214
Copy link
Contributor

@jiminkim214 jiminkim214 commented May 4, 2025

Summary

This pull request is the first step towards implementing feature Foo

  • added navigation from gameplay screen to quiz page
  • implemented quiz page(quiz_page.dart) and its features such as selecting answers, limited shuffling features, submitting the answer, and final completion message when quiz is over

Remaining TODOs:

  • need to fix the ui for completion message (when user selects incorrect or correct answer)
  • implement transition from completion message to point breakdown
  • fix the bear coin icon on the quiz page

Depends on #{number of PR}

Test Plan

used simulators to test

Notes

Blockers

  • A newly discovered dependency that hasn’t been addressed

Breaking Changes

  • Database schema change (anything that changes TypeORM entities)
  • Other change that could cause problems (Detailed in notes)

@CLAassistant
Copy link

CLAassistant commented May 4, 2025

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 445.

@ambers7
Copy link
Contributor

ambers7 commented May 4, 2025

Good job Jimin! I liked the clarifying comments for what each method does in quiz_page.dart; it might also be a good idea to have one big block comment at the top of the page explaining what the page does and the different parameters (a good example is gameplay_map.dart).

@3TTemi
Copy link
Collaborator

3TTemi commented May 5, 2025

Really nice work on modularity Jimin, makes the code a lot easier to read through. You're using a lot of statics, which I’d try to turn into constants for reusability, like this color: 0xFFE95755. I’d also stay away from using MediaQuery.devicePixelRatioOf and instead just use MediaQuery width and height to determine measurements since pixel density is hard to conceptualize.Overall looking good, just make sure to add more comments for the final PR and double check that things like asynchronous logic are working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants