-
Notifications
You must be signed in to change notification settings - Fork 1
quiz page #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
quiz page #262
Conversation
|
[diff-counting] Significant lines: 445. |
|
Good job Jimin! I liked the clarifying comments for what each method does in quiz_page.dart; it might also be a good idea to have one big block comment at the top of the page explaining what the page does and the different parameters (a good example is gameplay_map.dart). |
|
Really nice work on modularity Jimin, makes the code a lot easier to read through. You're using a lot of statics, which I’d try to turn into constants for reusability, like this color: 0xFFE95755. I’d also stay away from using MediaQuery.devicePixelRatioOf and instead just use MediaQuery width and height to determine measurements since pixel density is hard to conceptualize.Overall looking good, just make sure to add more comments for the final PR and double check that things like asynchronous logic are working correctly. |
Summary
This pull request is the first step towards implementing feature Foo
Remaining TODOs:
Depends on #{number of PR}
Test Plan
used simulators to testNotes
Blockers
Breaking Changes