-
Notifications
You must be signed in to change notification settings - Fork 1
Backend for Game Onboarding #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…rnell-dti/cornell-go into as4288/onboarding-backend
…rnell-dti/cornell-go into as4288/onboarding-backend
…erate frontend api layer
|
[diff-counting] Significant lines: 479. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The onboarding status logic and DTO additions are cleanly integrated. I'm wondering if there any potential migration concerns for existing users regarding the new hasCompletedOnboarding field?
|
Good job on this PR. Reviewing the logic, I believe this will successfully add the ability to track and reset a user's onboarding status. However, I noticed that only about 8 files had actual changes, and the rest were very small, like adding commas. Do you know why this happened? Are you using some type of formatter that is not Prettier (the one we adhere to in the codebase)? I also left a comment about differentiating between developer-made and generated code to ensure clarity for other developers. Otherwise, the logic looks good! |
admin/src didn't have a .prettierrc for formatting, so I added one in that was consistent with server/.prettierrc |
|
@ambers7 |
Fix code formatting with Prettier 3.6.2
|
The reasoning why server code style test was failing even after running Local: Prettier 2.8.8 (global) After I installed dependencies with npm install --legacy-peer-deps to get Prettier 3.6.2 locally and then reran formatting with Prettier 3.6.2 this was fixed |
Summary
Created the backend for storing, reading, and updating a user's onboarding status (if they have completed it or not).
This pull request is the first step towards implementing user onboarding when they first download CornellGO.
Test Plan
Breaking Changes