Skip to content

Conversation

@kea-roy
Copy link
Member

@kea-roy kea-roy commented Sep 19, 2024

This PR is a quick fix to remove some duplicated code from a merge error from my last semester's FAQ page PR. It removes duplicated styling code and invalid/unused mobile class names.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 166.

@kea-roy kea-roy marked this pull request as ready for review September 19, 2024 13:53
Copy link
Contributor

@ggsawatyanon ggsawatyanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the code base and for catching this! Good job on solidifying your understanding of code structure for useStyles/makeStyles and mobile display.

@ggsawatyanon ggsawatyanon merged commit 0895700 into main Sep 23, 2024
4 checks passed
@ggsawatyanon ggsawatyanon deleted the fix-faq-pr-merge-issues branch September 23, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants