Skip to content

Conversation

@ggsawatyanon
Copy link
Contributor

Summary

  • Removed emails of admins who are no longer on the team
  • Added new admins

Test Plan

Notes

Breaking Changes

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 12.

@kea-roy
Copy link
Member

kea-roy commented Sep 22, 2024

PR Review

I love how you cleanly removed the old admins and added the new admins. This is a pretty simple PR so there isn't much to critique.

However, I have some suggestions for ways this list could be further improved.

  1. It would be a good idea to be consistent with admin rights depending on role/subteam. For instance, add other developer leads to the admin list, given that Sophia maintains admin rights.
  2. Additionally, sorting the admin lists by each student's school year (senior, junior, etc..) may be more beneficial for easier addition and removal of names.
  3. This PR also reminds me of the need to move to a different admin system, where we track admins in the database instead of in a constant. Moving to such a system will provide admins more privacy and opportunities for easier management of admin rights in the future (ex: through a GUI).

Overall, this is a fabulously done PR and has no significant issues that need to be addressed.

@ggsawatyanon ggsawatyanon merged commit e02eab4 into main Sep 23, 2024
4 checks passed
@ggsawatyanon ggsawatyanon deleted the add-admins branch September 23, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants