Skip to content

Added Documentation for Toast #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

Added Documentation for Toast #371

merged 2 commits into from
Oct 4, 2024

Conversation

@ggsawatyanon
Copy link
Contributor

@ggsawatyanon ggsawatyanon commented Sep 23, 2024

Summary

This pull request adds documentation for the Toast component.

@dti-github-bot
Copy link
Member

dti-github-bot commented Sep 23, 2024 •
edited
Loading

[diff-counting] Significant lines: 18.

CasperL1218
CasperL1218 reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@CasperL1218 CasperL1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will might be helpful to include the specific colors corresponding to the different severity levels of the toast message.

@ggsawatyanon
Copy link
Contributor Author

ggsawatyanon commented Oct 4, 2024

Color documentation for the severity of the toast has now been added

CasperL1218
CasperL1218 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@CasperL1218 CasperL1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the colors makes it clear. Super detailed and helpful documentation!

@CasperL1218 CasperL1218 merged commit 5e3369f into main Oct 4, 2024
4 checks passed
@CasperL1218 CasperL1218 deleted the toast-documentation branch October 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CasperL1218 CasperL1218 CasperL1218 approved these changes

@kea-roy kea-roy Awaiting requested review from kea-roy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ggsawatyanon @dti-github-bot @CasperL1218