Implemented Delete Reviews Feature #372
Conversation
- this endpoint is not used, just added authentication to make sure api is robust. - adjusted authentication checks in update-review-status for security. - improved documentation on permissions
|
[diff-counting] Significant lines: 409. |
- create temporary delete modal for testing - create option menu temporary component
…lete dialog and option menu to match figma
…iews-from-edit Merged to update branch
…apts into delete-reviews-from-edit
kea-roy
changed the title
There was a problem hiding this comment.
This PR was really well done and I appreciate the extensive test plan description. Overall, this PR has achieved everything required by the task requirements. I only have 1 frontend change to request which is that when zooming in, the 3 dot menu (fun fact: also known as the "kebab menu" in the UI world) should always be at the top right of the review card (the first row) and other details like the date/price/bedrooms etc. can be on the second row. This is particularly noticeable with reviews that have the price and bedroom data and in different window sizes such as this example for the iPad Pro:
Or when zoomed in on a normal desktop:
No complains about mobile view!
- resolve padding issues - shorten date text on small screens to prevent wrapping - shorten bedrooms text on small screens to prevent wrapping - ensure kebab is always in correct position and doesn't wrap
…apts into delete-reviews-from-edit
PR ChangesFixed responsiveness of review
Test plan images: |
Summary
It can be really frustrating as a user when you post photos or other personal content in a review and have no way to completely remove a review.
With this feature, the delete reviews functionality provides users with more control over the data they provide to the platform.
Changes Made
What I've done:
Back-end:
Front-end:
End-to-End:
Test Plan
I conducted thorough testing of both the front-end and back-end features I implemented.
On the back-end, I tested the secured delete-review endpoint by ensuring that appropriate authentication measures were in place, even though the endpoint is not currently in use, to guarantee robustness in future use cases. I also verified the adjusted authentication checks in the update-review-status endpoint, ensuring that permissions were correctly enforced, and that the changes were accurately documented for future reference.
On the front-end, I tested the new icon menu by replacing the stub icons with those from Figma and confirming that clicking each option triggered the correct functionality. For the temporary delete confirmation dialog, I verified that it successfully connected with the ReviewComponent and accurately sent the delete request to the back-end API by creating dummy reviews to test on. Through both functional testing and manual interaction with the UI, I ensured that these implementations worked smoothly across their intended components. I also tested the responsiveness of the menu and delete pop up to make sure it works on all screen sizes.
For end-to-end testing, I made sure that when a user deletes their review, the page correctly refreshes immediately to reflect this change. I also refreshed the page and checked the database itself to make sure the review was successfully marked as deleted. I repeated this process for all pages, including bookmarks, profile, apartment, and landlord pages.
I've also tested regular user permissions by removing myself from the admin list and re-testing the above using postman. The API request successfully declines any review modification attempts except for deleting it and editing it.
Test Plan Photos from Responsiveness Testing