Resolved Screen Resizing Map Modal Content Cutoff Issue #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update apartment icon pin image - Remove development console log message - Added component documentation for MapInfo component
- Implemented map modal component - Removed driving time info from default map - Added landmark distance info to location information - Added documentation for map modal component Future tasks - Implement location info for modal map (landmarks, driving/waling time) - Implement recenter button functionality - Decrease marker size for apartment/landmarks to fit design
- Implemented recenter button - Updated icon for campus landmarks - Updated distance information layout for map modal
- Implemented zoom in/out buttons for small map and map modal - Resolved firebase import issues by adding new export and import statements
This reverts commit 3d99113.
- Implemented screen size detection hook - Changed modal and subcomponent sizing parameters to be responsive to screen size changes
|
[diff-counting] Significant lines: 722. |
- Added location landmark icons for map modal
ggsawatyanon
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Good job on completing this important map feature, Casper! You've worked super hard on this since last semester and improved your understanding of frontend a lot throughout implementing this feature. The adaptivity and mobile view for this is also seamless and looks great. Good job again :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of the closed PR #357.
This pull request is result of resolving the resizing issue of the map modal, where the information content in the map modal will be cutoff/overflow when screen size is reduced.
useThemereact hook).Test Plan
The same idea applies for non-full-screen screen sizes.
Notes