Batch Newsletter Service #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
April 13, 2025 16:16
- Update backend/.eslintrc.json to reference the correct tsconfig.json path - Enable JSX support in tsconfig.json with "jsx": "react-jsx"
- Create email sending scripts - Create basic components for newsletter
- Create assets folder in email directory - Add email icons to assets
- Create Newsletter templates - Create components for newsletter sections - Create generateNewsletter component to allow customization - Update README (WIP) - Update emailService to mail newsletter created by GenerateNewsletter
- Edit tsconfig to allow JSX in react files - Add working directory configuration in eslintrc to prevent parsing errors - TODO: figure out why these errors keep on occuring
- Create ReelsFeature, SubleaseSpotlight, FeatureSpotlight and NeighborhoodComparison components - Edit styling of existing newsletter components - Add prop types for new components to Types.tsx - Add new components to Newsletter template - Add customization options for new components in GenerateNewsletter
- Implement all components of Newsletter - Render property cards in AreaSpotlight and LandlordHighlight (based on property id) - TODO: finish styling, add documentation
- Add top-level documentation to all Newsletter components
- Load firebase users in batches of 50 - Implement script to send emails out to all users in loaded batches
- Update README for email directory - Update import in firebase_users_loader
|
Lauren Pothuru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 3 commits
April 30, 2025 10:02
- Fix relative vs absolute path in property fetch - Add info to README
CasperL1218
previously approved these changes
May 4, 2025
There was a problem hiding this comment.
This PR is comprehensive with a lot of detailed carried out well. Here are some main points to note:
- The README file is very informative and thorough. The "important" notices are helpful!
- For the styling of component, you could organize them with useStyle, which could make styling more intuitive and clear, and mainly more reusable. You could checkout the other files to see how it is done. (this is more of a code pattern issue, this could be done next semester on a separate task by you or someone else so no worries now)
- For backend/scripts/email/emailService.ts file, you have some commented out logic from line 84 to 92. It would be nice to remove them if they are no longer needed
added 2 commits
August 26, 2025 10:34
- Abstract unnecessary comments and clean up code - Fix environment variable handling in firebase config - Update README for clarity and formatting
|
[diff-counting] Significant lines: 2215. This diff might be too big! Developer leads are invited to review the code. |
- Update image icons for better compatibility - Add mobile header; prevent dark mode (only supported in some email clients) - Abstract email sending into separate functions
laurenp-2
changed the title
laurenp-2
changed the title
CasperL1218
reviewed
Sep 22, 2025
CasperL1218
reviewed
Sep 22, 2025
There was a problem hiding this comment.
Great implementation with good structured code and layout.
After conducting the testings, you could organize the test cases in a separate testing files to better separate feature and test files.
CasperL1218
requested changes
Sep 22, 2025
There was a problem hiding this comment.
Great implementation of the html template with the approach to resolve the preloading issues.
Some small details to clean up wrapping up include a brief check of removing unused/commented-out sections, organizing testing functions into a separata testing file for code quality and organization.
Looking forward to the new design updates and the admin end input! Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing the email service for batch newsletter distribution.
Completed features:
Test Plan
The backend route was tested using my email (so that no email campaigns were sent to CUApts users).
This is how a received Newsletter email appears on desktop (Gmail):
This is how a received newsletter appears on mobile (Apple mail app):
Note: Email clients render HTML and CSS differently, so emails may appear slightly different across inboxes. For example, Apple Mail supports custom fonts, while Gmail does not. The images above may also look different depending on the email client. Please test any emails that are being sent out vigorously among different clients to ensure consistent and responsive results!