-
Notifications
You must be signed in to change notification settings - Fork 3
Admin Newsletter Form #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laurenp-2
wants to merge
28
commits into
main
Choose a base branch
from
admin_newsletter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update backend/.eslintrc.json to reference the correct tsconfig.json path - Enable JSX support in tsconfig.json with "jsx": "react-jsx"
- Create email sending scripts - Create basic components for newsletter
- Create assets folder in email directory - Add email icons to assets
- Create Newsletter templates - Create components for newsletter sections - Create generateNewsletter component to allow customization - Update README (WIP) - Update emailService to mail newsletter created by GenerateNewsletter
- Edit tsconfig to allow JSX in react files - Add working directory configuration in eslintrc to prevent parsing errors - TODO: figure out why these errors keep on occuring
- Create ReelsFeature, SubleaseSpotlight, FeatureSpotlight and NeighborhoodComparison components - Edit styling of existing newsletter components - Add prop types for new components to Types.tsx - Add new components to Newsletter template - Add customization options for new components in GenerateNewsletter
- Implement all components of Newsletter - Render property cards in AreaSpotlight and LandlordHighlight (based on property id) - TODO: finish styling, add documentation
- Add top-level documentation to all Newsletter components
- Load firebase users in batches of 50 - Implement script to send emails out to all users in loaded batches
- Update README for email directory - Update import in firebase_users_loader
- Fix relative vs absolute path in property fetch - Add info to README
- Abstract unnecessary comments and clean up code - Fix environment variable handling in firebase config - Update README for clarity and formatting
- Update image icons for better compatibility - Add mobile header; prevent dark mode (only supported in some email clients) - Abstract email sending into separate functions
- Add newsletter tab in AdminPage - Create AdminNewsletter component for filling out and sending newsletters
- Added API endpoint to send newsletters - Integrated email service to dispatch newsletters - Updated frontend to include newsletter form and submission handling
|
Lauren Pothuru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
[diff-counting] Significant lines: 3076. This diff might be too big! Developer leads are invited to review the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements an Admin interface for managing and sending newsletters.
This feature enables admins to compose and distribute newsletters directly through the platform without external tools.
Test Plan
Admin Newsletter Form frontend:



Newsletter generated and sent with submitted information:
Error when there is invalid input:
Notes
Future improvements: