Combine 'Edit Profile' and 'Edit Profile Image' #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jane-leon
reviewed
Oct 27, 2025
| * uploads it to the server, and closes the modal. | ||
| */ | ||
| const cropAndSubmitImage = () => { | ||
| if (editor !== null) { |
There was a problem hiding this comment.
Looks amazing Esha, I really like how you added documentation. One thing I would point out is that currently inside the cropAndSubmitImage function, you're creating an object URL with window.URL.createObjectURL(blob) for the preview, but if a user is editing their profile image multiple times, we have quite a lot on our memory as there is like no cleanup being done. Otherwise, amazing!!
ladriennel
approved these changes
Nov 5, 2025
oscarwang20
approved these changes
Nov 5, 2025
|
[diff-counting] Significant lines: 111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is to combine the two pages - 'Edit Profile' and 'Edit Profile Image' - into just one. Essentially, the bulk of this is migrating the code in 'Edit Profile Image' into 'Edit Profile' and making sure it is integrated into the page properly.
Linear Link
Combine Edit Profile and Edit Profile Image
Test Plan
Notes
Need to update 'Edit Profile' tests to test for this addition