-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Google Account for Student Sign In #122
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated login page looks really good! I like how your testing plan is really thorough and how the new feature makes sure the student's email is a cornell email. When I was testing the first time, it wouldn't let me go to the dashboard from the survey page for some reason. I'm not sure if it's just me or a random situation, but if you have time you could look into that. However, it's minor so good job with implementing this new feature!
[diff-counting] Significant lines: 212. |
Visit the preview URL for this PR (updated for commit d47939d): https://zing-lsc--pr122-student-sign-in-e5wa3p9s.web.app (expires Fri, 25 Nov 2022 04:32:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1fc18307b178c916e2663810a6932f60b173c01b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Colin! I like how visually pleasing the new sign in page is, as well as how you check that the emails are valid Cornell emails using the existing infrastructure.
Summary
This pull request allows students to sign in using their cornell.edu account with Google Sign-in while filling out the student survey.
Test Plan
Testing was performed by filling out surveys using the new system and verifying that they were submitted correctly (new students show up on the dashboards and can be emailed to). Additional testing was also performed using admin accounts to make sure that email sending and dashboard access still work as intended despite the new sign in method.
Notes
Breaking Changes