[Bug] Brushing Feature Malfunction When Switching Active Segments in THRESHOLD_INSIDE_CIRCLE strategy

[stada526]

Describe the Bug

When using the THRESHOLD_INSIDE_CIRCLE strategy for brushing and switching the active segment from one to another, the brushing feature does not function as expected.
To illustrate the issue, I have modified the example code for segmentationVolume and prepared a reproducible case. stada526#2

Since the behavior is complex and difficult to describe accurately, please refer to the steps to reproduce below and the attached video.

(Note that these features used to function properly in Cornerstone.js v1)

Steps to Reproduce

Using my modified code stada526#2:
1. Click “Load DICOM”.
2. Click “Create Empty SEG” (let’s call it “segment1”).
3. Draw a segment.
4. Click “Create Empty SEG” again to create another segment (let’s call it “segment2”).
5. Draw a segment (the “segment2” will not be displayed).
6. Select “segment1” from the dropdown menu.
7. Draw a segment (the segment will not be displayed, but the “segment2” that wasn’t drawn in step 5 will now appear).

When using the normal brush mode by passing the BrushTool.toolName to setToolActive, this issue doesn't occur.

2024-12-20.12.30.26.mov

The current behavior

A newly drawn segment will not be displayed after switching the active segment.

The expected behavior

A newly drawn segment will be displayed even after switching the active segment.

OS

maxOS 15.1

Node version

v21.7.1

Browser

Chrome 130.0.6723.117

[sedghi]

is this still happening?

[stada526]

@sedghi
Hi, thank you for visiting this issue! Yes, this is still happening.

[stada526]

@sedghi
Hi, thank you so much for working on this issue! However, it hasn't been resolved yet.
The key point of this issue is that switching active segments doesn't work correctly in the THRESHOLD_INSIDE_CIRCLE strategy

You can still reproduce this issue by replacing CircularBrush with ThresholdCircle, and FILL_INSIDE_CIRCLE with THRESHOLD_INSIDE_CIRCLE in the example file of segmentationVolume.

[stada526]

Hi @sedghi ,
I was wondering if there are any updates on this issue.
I might be able to assist in resolving this bug, so if you have any idea where the bug may be occurring, could you share that information?

[sedghi]

I have a PR i wonder if it solves it #1820