fix(seg): Refactor LabelmapBaseTool and SphereScissorsTool to fix sphere bug in stack#1772
Merged
fix(seg): Refactor LabelmapBaseTool and SphereScissorsTool to fix sphere bug in stack#1772
Conversation
|
|
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to OHIF/Viewers#4700 & OHIF/Viewers#4643
fixes #1724, #1729
This pull request includes several changes to the
LabelmapBaseToolandSphereScissorsToolclasses to improve code organization and functionality. The most important changes include the introduction of new type definitions, modifications to existing methods, and removal of redundant code.Changes to
LabelmapBaseTool:createEditDatamethod to return a new typeEditDataReturnTypeand changed its access level to protected. [1] [2]getEditDatato handle the creation of edit data, which is now used withincreateEditData. [1] [2]getOperationDatamethod to return a new typeModifiedLabelmapToolOperationData. [1] [2]Changes to
SphereScissorsTool:SphereScissorsToolclass to use the newgetEditDatamethod fromLabelmapBaseTool, simplifying the logic for handling volume operations.Type Definitions and Imports:
EditDataReturnTypeandModifiedLabelmapToolOperationDatainLabelmapBaseTool.ts.LabelmapBaseTool.tsandSphereScissorsTool.ts. [1] [2] [3] [4]These changes aim to improve the maintainability and clarity of the codebase by introducing more specific type definitions and refactoring existing methods.