Skip to content

chore: off eslint and move to oxc 1.0 #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: off eslint and move to oxc 1.0 #2232

wants to merge 10 commits into from

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jul 29, 2025

This pull request introduces significant changes to the project's linting, formatting, and build systems, along with some codebase cleanup and modernization. The most important updates include replacing ESLint with Oxlint, updating Prettier configurations, and refactoring code for consistency and readability.

Linting and Formatting Updates:

  • Replaced ESLint with Oxlint across the project, including updates to linting commands in package.json and related files (.eslintrc.json removed, .oxlintrc.json added). [1] [2] [3] [4] [5] [6] [7]
  • Updated .prettierrc to include the @prettier/plugin-oxc plugin for better integration with Oxlint.

Build and Workflow Improvements:

  • Updated build workflows to replace format-check with lint in GitHub Actions and pre-commit hooks. [1] [2] [3]
  • Added a new format script to package.json for running Prettier on multiple file types.

Codebase Cleanup and Modernization:

  • Refactored packages/adapters/generate-dictionary.js for consistent string formatting and improved readability. [1] [2] [3] [4] [5]
  • Replaced any with unknown in type annotations for improved type safety.

Documentation Updates:

  • Reformatted and modernized documentation files, including Building.md and ImageIds.md, to use consistent heading styles. [1] [2]

Miscellaneous Changes:

  • Updated VS Code extension recommendations to include the Oxlint extension.
  • Removed unused or redundant dependencies from package.json, including ESLint-related plugins. [1] [2]

These changes streamline the development workflow, improve code quality, and enhance maintainability.

@sedghi sedghi changed the title off eslint chore: off eslint and move to oxc Jul 29, 2025
@sedghi sedghi changed the title chore: off eslint and move to oxc chore: off eslint and move to oxc 1.0 Jul 29, 2025
@wayfarer3130
Copy link
Collaborator

Is it possible to configure to detect line ending type and quote type from the file? It would be nice to not break formatting on dicom-microscopy-viewer, slim, dcmjs etc when used with this configuration.

@daker
Copy link
Contributor

daker commented Jul 30, 2025

@wayfarer3130 for those kind of settings, i use .editorconfig file(https://editorconfig.org) with the extension in vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants