fix: Ensure FOR is stored when required and cachedStats created #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedghi
approved these changes
Jul 30, 2025
wayfarer3130
commented
Jul 30, 2025
There was a problem hiding this comment.
This change just avoids needing to merge version.ts all the time. It will get recreated from package.json
wayfarer3130
commented
Jul 30, 2025
| @@ -80,9 +80,6 @@ export default class Length extends BaseAdapter3D { | |||
| trackingIdentifierTextValue: this.trackingIdentifierTextValue, | |||
| finding, | |||
| findingSites: findingSites || [], | |||
| ReferencedFrameOfReferenceUID: is3DMeasurement | |||
There was a problem hiding this comment.
This is moved to MeasurementReport.ts
wayfarer3130
commented
Jul 30, 2025
| @@ -185,6 +185,10 @@ export default class MeasurementReport { | |||
| is3DMeasurement | |||
| ); | |||
| args.ReferencedSOPSequence = ReferencedSOPSequence; | |||
| if (args.use3DSpatialCoordinates) { | |||
There was a problem hiding this comment.
This fixes the load of MPR measurements generally.
wayfarer3130
commented
Jul 30, 2025
| @@ -328,6 +332,7 @@ export default class MeasurementReport { | |||
| annotation: { | |||
| data: { | |||
| annotationUID, | |||
| cachedStats: {}, | |||
There was a problem hiding this comment.
This fixes missing cachedStats generally.
wayfarer3130
commented
Jul 30, 2025
There was a problem hiding this comment.
Recreated from package.json on each build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some of the annotation adapters weren't storing referenced frame of reference uid, nor were they creating cached stats.
Add both items automatically when appropriate.
Changes & Results
Add Ref FOR for 3d measurements
Add cached stats always
Testing
Link into OHIF and save 3d annotations.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment