Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 438 follow ups #440

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Mar 11, 2025

Issue #, if available:

Description of changes:

Follow-ups from PR #438:

  1. Tighten self test timeout and sleeps (discussed offline)
  2. Tighten and consolidate some test logic (see here)

Testing

In addition to CI, I ran the script exercising isFipsSelfTestFailureSkipAbort() == true:

$ TEST_JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto.x86_64 ./tests/ci/run_accp_basic_tests.sh --fips-self-test-failure-no-abort
...
BUILD SUCCESSFUL in 41m 21s
18 actionable tasks: 12 executed, 6 up-to-date

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@WillChilds-Klein WillChilds-Klein changed the title Pr 438 follow up PR 438 follow ups Mar 11, 2025
@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review March 11, 2025 16:07
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner March 11, 2025 16:07
@WillChilds-Klein WillChilds-Klein enabled auto-merge (squash) March 11, 2025 18:12
@WillChilds-Klein WillChilds-Klein merged commit f60a6e0 into corretto:main Mar 11, 2025
11 checks passed
@geedo0
Copy link
Contributor

geedo0 commented Mar 11, 2025

Thanks for following up on these

@WillChilds-Klein WillChilds-Klein deleted the pr-438-follow-up branch March 11, 2025 20:04
chockalingamc pushed a commit to chockalingamc/amazon-corretto-crypto-provider that referenced this pull request Mar 12, 2025
Follow-ups from PR corretto#438:

1. Tighten self test timeout and sleeps (discussed offline)
2. Tighten and consolidate some test logic (see [here][1])

[1]:
corretto#438 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants