Upgrade gradle wrapper to version 8.5 for JDK21 support #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chockalingamc
changed the title
geedo0
reviewed
Mar 13, 2025
build.gradle
Outdated
| @@ -647,11 +643,23 @@ task coverage { | |||
| dependsOn coverage_java_report | |||
| } | |||
|
|
|||
| // Since gradle upgrade to 8.13, Gradle macOS CI workflow fails with this error: | |||
There was a problem hiding this comment.
Since we're using Gradle 8.5 now, do we still need this workaround? Want to avoid changing anything we don't need to.
There was a problem hiding this comment.
will remove for now and add back when upgrading to 8.13
tests/ci/run_accp_basic_tests.sh
Outdated
| @@ -64,10 +64,30 @@ fi | |||
| export JAVA_HOME=$TEST_JAVA_HOME | |||
| export PATH=$JAVA_HOME/bin:$PATH | |||
|
|
|||
| # Since gradle upgrade to 8.13, Gradle macOS CI workflow fails with this error: | |||
added 6 commits
March 13, 2025 14:49
In prep for full Java 21 support, gradle needs to be updated to version 8.5 or later. https://docs.gradle.org/8.5/release-notes.html#java-21 https://docs.gradle.org/8.5/userguide/compatibility.html#java Updating gradle to latest version available now (8.13). Also upgrading plugin 'com.google.osdetector' to version '1.7.3' to fix gradle deprecation warnings.
This reverts commit 2d3b401.
chockalingamc
force-pushed
the
gradle_upgrade
branch
from
f2d468c to
f30a62c
Compare
geedo0
approved these changes
Mar 13, 2025
chockalingamc
changed the title
WillChilds-Klein
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
nice. thanks for cleaning this up. did recent gradle versions stop writing this JAR? if not, is it something we should add to .gitignore?
There was a problem hiding this comment.
Every new gradle version should have some update to the wrapper jar. The difference is not visible here, but shows up well in IDE diff. We should keep checking in the updated JAR to git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade gradle wrapper to version 8.5 for JDK21 support
Issue #: 332
Description of changes:
In prep for full Java 21 support, gradle needs to be updated to version 8.5 or later.
https://docs.gradle.org/8.5/release-notes.html#java-21
https://docs.gradle.org/8.5/userguide/compatibility.html#java
Note: Tried updating gradle to the latest version available now (8.13), but that failed CI tests with linker errors on legacy platforms (newer GLIBC_2.14 not available in older Ubuntu 10.04 platform). So staying with 8.5 until legacy builds are deprected.
Also upgrading plugin 'com.google.osdetector' to version '1.7.3' to fix gradle deprecation warnings.
(Closed out a old PR #437 related to this and starting clean from latest main branch)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.