-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gradle wrapper to version 8.5 for JDK21 support #442
Conversation
build.gradle
Outdated
@@ -647,11 +643,23 @@ task coverage { | |||
dependsOn coverage_java_report | |||
} | |||
|
|||
// Since gradle upgrade to 8.13, Gradle macOS CI workflow fails with this error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're using Gradle 8.5 now, do we still need this workaround? Want to avoid changing anything we don't need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove for now and add back when upgrading to 8.13
tests/ci/run_accp_basic_tests.sh
Outdated
@@ -64,10 +64,30 @@ fi | |||
export JAVA_HOME=$TEST_JAVA_HOME | |||
export PATH=$JAVA_HOME/bin:$PATH | |||
|
|||
# Since gradle upgrade to 8.13, Gradle macOS CI workflow fails with this error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
In prep for full Java 21 support, gradle needs to be updated to version 8.5 or later. https://docs.gradle.org/8.5/release-notes.html#java-21 https://docs.gradle.org/8.5/userguide/compatibility.html#java Updating gradle to latest version available now (8.13). Also upgrading plugin 'com.google.osdetector' to version '1.7.3' to fix gradle deprecation warnings.
This reverts commit 2d3b401.
f2d468c
to
f30a62c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. thanks for cleaning this up. did recent gradle versions stop writing this JAR? if not, is it something we should add to .gitignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every new gradle version should have some update to the wrapper jar. The difference is not visible here, but shows up well in IDE diff. We should keep checking in the updated JAR to git.
Upgrade gradle wrapper to version 8.5 for JDK21 support
Issue #: 332
Description of changes:
In prep for full Java 21 support, gradle needs to be updated to version 8.5 or later.
https://docs.gradle.org/8.5/release-notes.html#java-21
https://docs.gradle.org/8.5/userguide/compatibility.html#java
Note: Tried updating gradle to the latest version available now (8.13), but that failed CI tests with linker errors on legacy platforms (newer GLIBC_2.14 not available in older Ubuntu 10.04 platform). So staying with 8.5 until legacy builds are deprected.
Also upgrading plugin 'com.google.osdetector' to version '1.7.3' to fix gradle deprecation warnings.
(Closed out a old PR #437 related to this and starting clean from latest main branch)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.