Skip to content

refactor more cpp #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gocarlos wants to merge 17 commits into
base: master
Choose a base branch
from
Open

refactor more cpp #122

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0049baf
refactor: put CoseKey in its header, less header inclusions
gocarlos May 25, 2020
6e2b4b3
refactor: less header inclusions
gocarlos May 25, 2020
41a3464
refactor: more nullptr
gocarlos May 25, 2020
3a31c9a
refactor: split types into header files
gocarlos May 25, 2020
7c2f48a
refactor: add meaningful name to some vars
gocarlos May 25, 2020
f01dcba
refactor: default initialize variables to 0
gocarlos May 25, 2020
8c4938e
style: format source code
gocarlos May 25, 2020
8465741
fix: add missing headers
gocarlos May 25, 2020
fad5850
fix: inclusion of headers for encrypt.cpp
gocarlos May 25, 2020
2428a21
Rename enveloped.hpp to Enveloped.hpp
gocarlos May 25, 2020
160a58f
fix: includes for signerinfo
gocarlos May 25, 2020
e1b0d0f
style: improve readibility of comments
gocarlos May 25, 2020
13fef8b
refactor: cleanup some unused variables
gocarlos May 25, 2020
2c51328
fix: includes for macmessage.cpp
gocarlos May 25, 2020
489d972
build: fix clang tidy
gocarlos May 25, 2020
2c45ed6
refactor: smaller cleanups
gocarlos May 25, 2020
b3c4990
fix: more includes
gocarlos May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dumper/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${dist_dir}/dumper)

add_executable(cose_dumper dumper.c)
add_executable(cose_dumper dumper.cpp)
target_link_libraries(cose_dumper PRIVATE cn-cbor::cn-cbor cose-c::cose-c)
if(MSVC)
target_link_libraries(cose_dumper PRIVATE ws2_32)
endif()

target_include_directories(cose_dumper PRIVATE ../src)
target_compile_options(cose_dumper PRIVATE "-fpermissive")
Copy link
Member Author

@gocarlos gocarlos May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we are using cpp, we can overload functions -> we should get rid if macros that insert , context to the argument list IMHO

Copy link
Contributor

@jimsch jimsch May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not going to be possible to remove all of these macros as the CBOR library is still in C. I am also not too sure how much one can rely on linkers to not require functions exist, I know that one can compile each function into a separate block for MSVC but I don't know for sure that this exists in gcc and clang as they are not the compilers that I use much


if(COSE_C_USE_MBEDTLS)
# mbedtls
Expand Down
Loading