Address elements of Linda Dunbar's review #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henkbirkholz
reviewed
Jul 8, 2025
achamayou
commented
Jul 8, 2025
achamayou
commented
Jul 8, 2025
Co-authored-by: Amaury Chamayou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One bit of the review is addressed by #55, this adds:
(requested assignment ...)next to TBD_* to resolve consistency. We could also change to the allocated valued everywhere, but the consensus in the last meeting was against that.I have left the COSE Receipts definition unchanged, because although it is a little awkward, it is consistent with other header parameter definitions that follow, and I don't think it is ambiguous.