Skip to content

replace axios with cross-fetch #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace axios with cross-fetch #1645

wants to merge 1 commit into from

Conversation

dynst
Copy link

@dynst dynst commented May 4, 2025

Closes #1627

@dynst dynst force-pushed the fetch-happened branch from 639c3b2 to fe5347b Compare May 4, 2025 12:57
webmaster128
webmaster128 reviewed Jun 4, 2025
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/tendermint-rpc/src/rpcclients/http.ts
@@ -40,7 +19,7 @@ export async function http(
headers: Record<string, string> | undefined,
request?: any,
): Promise<any> {
if (typeof fetch === "function" && !isExperimental(fetch)) {
if (typeof fetch === "function") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we assume fetch is always there, I think we should remove this if. Another option would be a helpful error message in the else case.

@dynst dynst force-pushed the fetch-happened branch from fe5347b to ff9cf5d Compare June 4, 2025 17:01
@dynst dynst force-pushed the fetch-happened branch from ff9cf5d to efd73c3 Compare June 4, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace Axios with Fetch API
2 participants
@dynst @webmaster128