wip: state migration msg #169
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: finish feegrants and work on pagination
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // =============== | ||
| func (k *Keeper) migrateDelegations(ctx sdk.Context, originalAddress sdk.AccAddress, maxValidators uint16, newAddress sdk.AccAddress) error { | ||
|
|
||
| delegations, err := k.stakingKeeper.GetDelegatorDelegations(ctx, originalAddress, maxValidators) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 17 days ago
To fix the issue, we should remove the unused assignment to the err variable on line 39. Since the delegations variable is used in the subsequent loop, we can retain the call to k.stakingKeeper.GetDelegatorDelegations but discard the unused err assignment by replacing it with the blank identifier _. This ensures that the code remains functional while eliminating the unnecessary variable assignment.
Suggested changeset
1
x/vm/keeper/account_migration.go
| @@ -38,3 +38,3 @@ | ||
|
|
||
| delegations, err := k.stakingKeeper.GetDelegatorDelegations(ctx, originalAddress, maxValidators) | ||
| delegations, _ := k.stakingKeeper.GetDelegatorDelegations(ctx, originalAddress, maxValidators) | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: finish feegrants and work on pagination
closes: #147